-
Notifications
You must be signed in to change notification settings - Fork 1.7k
AMBARI-23032 export cluster as blueprint for 3.0 #1367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 21 commits
63083ec
4ec0391
bd2f0b3
33c0f20
aba404a
c31829c
91f1560
0d21dad
bf1e23c
fdbed57
1277c6e
2631e7d
3024885
cf468a6
bb94bb7
424e420
66cbcae
b5ecffb
f8c7cdb
2c424dd
9683e29
b30770f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -88,6 +88,7 @@ public StackId getStackId() { | |
| public String getMpackInstance() { | ||
| return this.mpackInstance; | ||
| } | ||
|
|
||
| /** | ||
| * @return the service instance this component belongs to. Can be {@code null} if component does not belong to a service | ||
| * instance (there is a single service of the component's service type) | ||
|
|
@@ -99,7 +100,7 @@ public String getServiceInstance() { | |
| /** | ||
| * Gets the provision action associated with this component. | ||
| * | ||
| * @return the provision action for this component, whichRequest's Mpack instances isRequest's Mpack instances is | ||
| * @return the provision action for this component, which | ||
| * may be null if the default action is to be used | ||
| */ | ||
| public ProvisionAction getProvisionAction() { | ||
|
|
@@ -126,6 +127,7 @@ public boolean equals(Object o) { | |
| return Objects.equals(name, component.name) && | ||
| Objects.equals(stackId, component.stackId) && | ||
| Objects.equals(mpackInstance, component.mpackInstance) && | ||
| Objects.equals(stackId, component.stackId) && | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is the same "Objects.equals(stackId, component.stackId)" line added in two places in this equals() implementation? Is this a typo?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like a merge issue. Thanks for spotting it. |
||
| Objects.equals(serviceInstance, component.serviceInstance) && | ||
| provisionAction == component.provisionAction; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1363 is changing service group response in the opposite way (return
"version"instead of"stack"). I think these strings should be defined in a constant inServiceGroupResourceProvider(also"mpack_name"etc.).