[v3-1-test] Refactor AuthManager from app.state to FastAPI dependency (#57665) #57814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create new auth_manager.py module in common with AuthManagerDep - Update security.py to use AuthManagerDep instead of request.app.state.auth_manager - Update auth.py routes to use AuthManagerDep - Remove Request parameter where no longer needed - Follow the same dependency injection pattern as DagBag Add unit tests for auth_manager dependency injection - Create test_auth_manager.py to test the new dependency - Verify auth_manager_from_app correctly retrieves from app.state - Test integration with existing test client fixture Fix linting issues with ruff - Move BaseAuthManager import out of TYPE_CHECKING block - Fix import ordering in security.py - Remove unused pytest import from test - Remove trailing whitespace - Format code with ruff format Move auth_manager dependency to security.py module - Move auth_manager_from_app and AuthManagerDep from common/auth_manager.py to core_api/security.py - Update import in routes/public/auth.py to use security module - Move tests from common/test_auth_manager.py to core_api/test_security.py - Delete now-unused common/auth_manager.py and common/test_auth_manager.py - Import BaseAuthManager directly in security.py (not in TYPE_CHECKING) Co-authored-by: copilot-swe-agent[bot] <[email protected]> (cherry picked from commit 1242e07)
jason810496
requested review from
bugraoz93,
ephraimbuddy,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests for auth_manager dependency injection
Fix linting issues with ruff
Move auth_manager dependency to security.py module
(cherry picked from commit 1242e07)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.