Remove global from settings part1 #57705
Open
+22
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
force-pushed
the
bugfix/remove-global-from-settings-part1
branch
2 times, most recently
from
b17e8cc to
15e57f9
Compare
jscheffl
force-pushed
the
bugfix/remove-global-from-settings-part1
branch
from
15e57f9 to
1d938af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was attempting to clean code toward ruff rule PLW0603 (https://docs.astral.sh/ruff/rules/global-statement/) I noticed that some code is a bit... outdated to be refactored. Making some smaller PRs for the cleanup of PLW0603 assuming easier to review
This PR attempts to remove the global keyword from settings objects module. It was mainly used as a cache, so replaced it with functools.cache
As there are a couple of global statements and the settings class is a historical hairball, this is a small part 1 PR which removes the two variables only: