-
Notifications
You must be signed in to change notification settings - Fork 15.9k
Enable ruff PLW1641 rule #57679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ruff PLW1641 rule #57679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Shouldn't we include the rule (PLW1641) in pyproject.toml? Maybe it is coming as default that I am not 100% sure, wanted to point out .
Sorry, it is there, my bad! Was checking this through phone, something tricked me there 🤦
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 58fc860 v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
(cherry picked from commit 58fc860) Co-authored-by: Jens Scheffler <[email protected]>
(cherry picked from commit 58fc860) Co-authored-by: Jens Scheffler <[email protected]>
(cherry picked from commit 58fc860) Co-authored-by: Jens Scheffler <[email protected]>
While implementing #57294 I realized that a couple of more ruff PLW rules might be interesting, this PR enables PLW1641
See also https://docs.astral.sh/ruff/rules/#warning-plw