Skip to content

[v3-1-test] Add number of queries guard for public tasks (#57646) #57664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
Merged

[v3-1-test] Add number of queries guard for public tasks (#57646) #57664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
from airflow.sdk import DAG
from airflow.sdk.definitions._internal.expandinput import EXPAND_INPUT_EMPTY

from tests_common.test_utils.asserts import assert_queries_count
from tests_common.test_utils.dag import sync_dag_to_db, sync_dags_to_db
from tests_common.test_utils.db import (
clear_db_dag_bundles,
Expand Down Expand Up @@ -386,7 +387,8 @@ def test_should_respond_200(self, test_client):
],
"total_entries": 2,
}
response = test_client.get(f"{self.api_prefix}/{self.dag_id}/tasks")
with assert_queries_count(2):
response = test_client.get(f"{self.api_prefix}/{self.dag_id}/tasks")
assert response.status_code == 200
assert response.json() == expected

Expand Down Expand Up @@ -460,7 +462,9 @@ def test_get_tasks_mapped(self, test_client):
],
"total_entries": 2,
}
response = test_client.get(f"{self.api_prefix}/{self.mapped_dag_id}/tasks")

with assert_queries_count(2):
response = test_client.get(f"{self.api_prefix}/{self.mapped_dag_id}/tasks")
assert response.status_code == 200
assert response.json() == expected

Expand Down Expand Up @@ -514,23 +518,27 @@ def test_get_unscheduled_tasks(self, test_client):
],
"total_entries": len(downstream_dict),
}
response = test_client.get(f"{self.api_prefix}/{self.unscheduled_dag_id}/tasks")

with assert_queries_count(2):
response = test_client.get(f"{self.api_prefix}/{self.unscheduled_dag_id}/tasks")
assert response.status_code == 200
assert response.json() == expected

def test_should_respond_200_ascending_order_by_start_date(self, test_client):
response = test_client.get(
f"{self.api_prefix}/{self.dag_id}/tasks?order_by=start_date",
)
with assert_queries_count(2):
response = test_client.get(
f"{self.api_prefix}/{self.dag_id}/tasks?order_by=start_date",
)
assert response.status_code == 200
assert self.task1_start_date < self.task2_start_date
assert response.json()["tasks"][0]["task_id"] == self.task_id
assert response.json()["tasks"][1]["task_id"] == self.task_id2

def test_should_respond_200_descending_order_by_start_date(self, test_client):
response = test_client.get(
f"{self.api_prefix}/{self.dag_id}/tasks?order_by=-start_date",
)
with assert_queries_count(2):
response = test_client.get(
f"{self.api_prefix}/{self.dag_id}/tasks?order_by=-start_date",
)
assert response.status_code == 200
# - means is descending
assert self.task1_start_date < self.task2_start_date
Expand Down