Enable ruff PLW1509 rule #57659
Merged
Enable ruff PLW1509 rule #57659
+8
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
force-pushed
the
feature/add-ruff-plw1509-rule
branch
2 times, most recently
from
6e9db94 to
e8588ad
Compare
jscheffl
force-pushed
the
feature/add-ruff-plw1509-rule
branch
2 times, most recently
from
9224ca3 to
d72c723
Compare
eladkal
approved these changes
Nov 6, 2025
jscheffl
force-pushed
the
feature/add-ruff-plw1509-rule
branch
from
d72c723 to
8b2504c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing #57294 I realized that a couple of more ruff PLW rules might be interesting, this PR enables PLW1509 - and adds fixes as needed.
Fun stuff that we had especially in standard provider really a long time deprecated fucntion. I was able to trace the usage back to the year 2017 in ca96104 where it was initially added which was closing https://issues.apache.org/jira/browse/AIRFLOW-1745 (for somebody still having access to this...).
So for the change in standard provider - as far as I see the docs all supported python versions allow a replacement but I'd like really a "gray hair person" expertise review by e.g. @ashb @kaxil @potiuk @dstandish (including these who still have hair...) if the replacement code is really good enough.
See also https://docs.astral.sh/ruff/rules/#warning-plw