-
Notifications
You must be signed in to change notification settings - Fork 15.9k
Second cut at verifying team/bundle at dag parse time #57166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
o-nikolas
merged 2 commits into
apache:main
from
aws-mwaa:onikolas/dag_bag_team_executor_verification
Oct 27, 2025
Merged
Second cut at verifying team/bundle at dag parse time #57166
o-nikolas
merged 2 commits into
apache:main
from
aws-mwaa:onikolas/dag_bag_team_executor_verification
Oct 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle path is already plumbed down to the dag bag for parsing, also pass along the bundle name which is used to lookup the bundle config and find the team name from bundle configuration. This is used to verify that tasks/dags are using executors that are available/configured for their team.
Contributor
Author
|
This one should now be ready for review @vincbeck and @jedcunningham |
potiuk
approved these changes
Oct 25, 2025
Member
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
vincbeck
approved these changes
Oct 27, 2025
o-nikolas
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Oct 31, 2025
Providing the bundle name is critical for verification of team/executor verification. This construction of DagBag was missed in apache#57166
o-nikolas
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Oct 31, 2025
Providing the bundle name is critical for verification of team/executor verification. This construction of DagBag was missed in apache#57166
o-nikolas
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Oct 31, 2025
Providing the bundle name is critical for verification of team/executor verification. This construction of DagBag was missed in apache#57166
o-nikolas
added a commit
that referenced
this pull request
Nov 4, 2025
* Add bundle_name to DagBag during execution time parse() Providing the bundle name is critical for verification of team/executor verification. This construction of DagBag was missed in #57166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundle path is already plumbed down to the dag bag for parsing, also pass along the bundle name which is used to lookup the bundle config and find the team name from bundle configuration.
This is used to verify that tasks/dags are using executors that are available/configured for their team.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.