Skip to content

Conversation

@hogan-tech
Copy link

Description

This PR fixes a UI bug in the Pools List page where the "Delete" (remove filter) button for search filters was not fully visible. The issue was caused by legacy table cell (td) settings in the template, which became problematic after upgrading the Flask-AppBuilder package. The button was partially hidden, with only its right border visible, making it difficult for users to remove filters.

What was changed:

  • Adjusted the table cell settings in pool_list.html to ensure the remove filter button is always fully visible and accessible in the Pools List filter UI.

How to reproduce

  1. Go to AdminPools in the Airflow UI (Admin tab → Pools button in dropdown).
  2. Click the search filter button.
  3. Observe that the delete (remove filter) button is not fully visible (only the right border shows).

What you think should happen instead

The delete search filter button should be fully visible and easily clickable.

Related PRs

Additional context

  • This issue appeared after upgrading Flask-AppBuilder, which changed some default table rendering behaviors.
  • The fix is backward-compatible and only affects the Pools List page.

Screenshots

Before:

Screenshot 2025-05-28 at 10 30 00 PM

After:

Screenshot 2025-05-28 at 10 30 40 PM

Please review and let me know if further adjustments are needed.

@Lee-W Lee-W added area:UI Related to UI/UX. For Frontend Developers. legacy ui Whether legacy UI change should be allowed in PR labels May 28, 2025
@bbovenzi bbovenzi added this to the Airflow 2.11.1 milestone May 28, 2025
@bbovenzi bbovenzi merged commit b3a3591 into apache:v2-11-test May 28, 2025
42 checks passed
@hogan-tech hogan-tech deleted the fix/v2-11-test/pool-remove-filter-visibility branch May 30, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. legacy ui Whether legacy UI change should be allowed in PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants