allow passing custom env to log groomer sidecar containers #46003
+45
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgvishnuram
requested review from
dstandish,
jedcunningham and
hussein-awala
as code owners
amoghrajesh
reviewed
Jan 24, 2025
In every component of airflow helm template it was defined that way - so i included the same approach. I doesnt require we can directly do a toYaml directly as well |
This was referenced Jan 24, 2025
| env: | ||
| {{- if .Values.dagProcessor.logGroomerSidecar.retentionDays }} | ||
| - name: AIRFLOW__LOG_RETENTION_DAYS | ||
| value: "{{ .Values.dagProcessor.logGroomerSidecar.retentionDays }}" | ||
| - name: AIRFLOW_HOME |
There was a problem hiding this comment.
Like discussed here, we should set AIRFLOW_HOME regardless.
| @@ -12175,6 +12175,16 @@ | |||
| "type": "integer", | |||
| "default": 15 | |||
| }, | |||
| "env": { | |||
| "description": "Add additional env vars to log groomer sidecar container.", | |||
There was a problem hiding this comment.
Suggested change
| "description": "Add additional env vars to log groomer sidecar container.", | |
| "description": "Add additional env vars to log groomer sidecar container (templated).", |
| @@ -90,6 +90,19 @@ def test_log_groomer_collector_default_retention_days(self): | |||
| ) | |||
| assert jmespath.search("spec.template.spec.containers[1].env[0].value", docs[0]) == "15" | |||
|
|
|||
| def test_log_groomer_collector_custom_env(self): | |||
| env = {"name": "ENABLE_KUBE_MUTATION_TYPE", "value": "upsert"} | |||
There was a problem hiding this comment.
It'd be worth refactoring this test so it exercises the templating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description:
Currently logGroomer sidecar container does not allow users to pass custom env vars
Changes:
This PR introduces env vars support for all the log groomer sidecars to allow overridable env vars to those components