Run the task with the configured dag bundle #44752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:Executors-core
dstandish
force-pushed
the
run-the-configured-bundle
branch
from
5fd9bfe to
6553836
Compare
dstandish
commented
Dec 6, 2024
dstandish
commented
Dec 9, 2024
dstandish
force-pushed
the
run-the-configured-bundle
branch
2 times, most recently
from
6724f00 to
45b68d0
Compare
dstandish
force-pushed
the
run-the-configured-bundle
branch
from
45b68d0 to
042fb04
Compare
dstandish
force-pushed
the
run-the-configured-bundle
branch
5 times, most recently
from
ff2b6d2 to
0a7e0ad
Compare
dstandish
force-pushed
the
run-the-configured-bundle
branch
2 times, most recently
from
bfa70db to
c9ccedd
Compare
dstandish
requested review from
ephraimbuddy,
potiuk,
XD-DENG,
ashb,
o-nikolas,
pierrejeambrun and
hussein-awala
as code owners
dstandish
force-pushed
the
run-the-configured-bundle
branch
from
5487556 to
80000c1
Compare
jedcunningham
approved these changes
Jan 14, 2025
1 task
dstandish
force-pushed
the
run-the-configured-bundle
branch
from
80000c1 to
472f578
Compare
jedcunningham
approved these changes
Jan 14, 2025
dstandish
added
the
full tests needed
dstandish
force-pushed
the
run-the-configured-bundle
branch
from
c9757db to
f1d744f
Compare
jedcunningham
approved these changes
Jan 14, 2025
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
Ensures that dag runs are created with a reference to the bundle that was in effect at the time. And when a dag run has bundle info, the task will be run with that dag bundle version.
dauinh
pushed a commit
to dauinh/airflow
that referenced
this pull request
Jan 24, 2025
Ensures that dag runs are created with a reference to the bundle that was in effect at the time. And when a dag run has bundle info, the task will be run with that dag bundle version.
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
Ensures that dag runs are created with a reference to the bundle that was in effect at the time. And when a dag run has bundle info, the task will be run with that dag bundle version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we ensure that when a dag run is created, we stamp the current bundle version on the dag run so that we can ensure the run is run with the right bundle version. Then i make sure it flows through properly to the task run context where it's checked out and loaded.
I also rename 'path' or 'file' to
dag_rel_pathin some parts of the execution machinery, so that it's clear where we are using the relative path and the absolute path.