AIP-72: Add support for fetching variables and connections in Supervisor #44229
+203
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
added
the
area:task-execution-interface-aip72
kaxil
commented
Nov 21, 2024
kaxil
force-pushed
the
add-variables-connections-task-sdk
branch
from
0175650
to
85d1bb0
Compare
kaxil
commented
Nov 21, 2024
kaxil
commented
Nov 21, 2024
kaxil
commented
Nov 21, 2024
kaxil
force-pushed
the
add-variables-connections-task-sdk
branch
from
85d1bb0
to
96068da
Compare
ashb
reviewed
Nov 21, 2024
kaxil
force-pushed
the
add-variables-connections-task-sdk
branch
from
96068da
to
c6e14bb
Compare
ashb
reviewed
Nov 21, 2024
ashb
reviewed
Nov 21, 2024
kaxil
force-pushed
the
add-variables-connections-task-sdk
branch
2 times, most recently
from
d283723
to
42ddd22
Compare
- Updated `VariableOperations` and `ConnectionOperations` in `Client`: - Added `get` methods for fetching variable and connection details. - Refactored communication protocol (`comms.py`): - Unified result models (`ConnectionResult`, `VariableResult`, `XComResult`) extending auto-generated models. - Renamed `ReadXCom` to `GetXCom` for consistency with other request models (`GetConnection`, `GetVariable`). - Updated `WatchedSubprocess` in `supervisor.py`: - Integrated `handle_requests` to process `GetVariable` and `GetConnection` messages. and some minor refactors
kaxil
force-pushed
the
add-variables-connections-task-sdk
branch
from
42ddd22
to
bfba2b9
Compare
ashb
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VariableOperationsandConnectionOperationsinClient:getmethods for fetching variable and connection details.comms.py):ConnectionResult,VariableResult,XComResult) extending auto-generated models.ReadXComtoGetXComfor consistency with other request models (GetConnection,GetVariable).WatchedSubprocessinsupervisor.py:handle_requeststo processGetVariableandGetConnectionmessages.and some minor refactors -- check inline comments
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.