Migrate public endpoint Patch Task Instance to FastAPI #44223
Conversation
boring-cyborg
bot
added
area:API
omkar-foss
added
the
legacy api
omkar-foss
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl and
ephraimbuddy
as code owners
|
All checks passed, PR is ready for review ✅ |
|
@pierrejeambrun I'm adding the Set Task Instance Note functionality to this (Patch Task Instance) API as you mentioned here. Will update this PR in a while. |
omkar-foss
force-pushed
the
aip-84/tis/patch-ti
branch
from
addcfe1
to
f6c3f24
Compare
| if len(note) > 1000: | ||
| raise ValueError("Note length should not exceed 1000 characters.") |
There was a problem hiding this comment.
This exists natively in pydantic Field. We can use that instead of coding a check manually.
| request: Request, | ||
| body: PatchTaskInstanceBody, | ||
| session: Annotated[Session, Depends(get_session)], | ||
| map_index: int = -1, |
There was a problem hiding this comment.
We are missing the update mask.
You can take a look at others (not all of them are reworked yet), but patch_dag_run might be close to what you want.
Also, if mask is provided, None values should not be ignored but set to None.
|
|
||
| dry_run: bool = True | ||
| new_state: str | None = None | ||
| note: str | None = None |
There was a problem hiding this comment.
https://docs.pydantic.dev/latest/api/types/#pydantic.types.StringConstraints
| note: str | None = None | |
| note: Annotated[str, StringConstraints(max_length=1000)] | None = None |
There was a problem hiding this comment.
Yes that one.
Thanks for your input @Kludex :)
| if len(note) > 1000: | ||
| raise ValueError("Note length should not exceed 1000 characters.") |
closes: #43753 and #43754
related: #42370
This migrates the Patch Task Instance API from
api_connexiontoapi_fastapi.