Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't exit doc preparation even if changelog is empty for any provider #44207

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amoghrajesh
Copy link
Contributor

@eladkal found an edge case where if any provider doesn't have a changelog to process, the process of breeze release-management generate-issue-content-providers exits and doesn't continue ahead.

How was this tested?

  1. Cleared the changelog entirely for standard provider to ensure it has no PRs to process
  2. Ran the breeze release-management generate-issue-content-providers command before changes:
Skipping extracting PRs for provider qdrant as it is missing in dist
Skipping extracting PRs for provider redis as it is missing in dist
Skipping extracting PRs for provider salesforce as it is missing in dist
Skipping extracting PRs for provider samba as it is missing in dist
Skipping extracting PRs for provider segment as it is missing in dist
Skipping extracting PRs for provider sendgrid as it is missing in dist
Skipping extracting PRs for provider sftp as it is missing in dist
Skipping extracting PRs for provider singularity as it is missing in dist
Extracting PRs for provider slack
Extracting PRs for provider smtp
Extracting PRs for provider snowflake
Extracting PRs for provider sqlite
Skipping extracting PRs for provider ssh as it is missing in dist
Extracting PRs for provider standard
Skipping provider standard. The changelog file doesn't contain any PRs for the release.
  1. Ran the same command after the changes:
Extracting PRs for provider smtp
Extracting PRs for provider snowflake
Extracting PRs for provider sqlite
Extracting PRs for provider ssh
Extracting PRs for provider standard
I AM HERE for standard
Skipping provider standard. The changelog file doesn't contain any PRs for the release.

Extracting PRs for provider tableau
Extracting PRs for provider telegram
Extracting PRs for provider teradata
Extracting PRs for provider trino
Extracting PRs for provider vertica
Extracting PRs for provider weaviate
Extracting PRs for provider yandex


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@amoghrajesh amoghrajesh changed the title Continue preparing provider docs even if changelog is empty for any provider Don't exit doc preparation even if changelog is empty for any provider Nov 20, 2024
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amoghrajesh amoghrajesh reopened this Nov 20, 2024
@potiuk
Copy link
Member

potiuk commented Nov 21, 2024

Hmm... there seem to be error generated by that however (see failing tests) - looks like it expects to have provider in the dictionary and it does not find it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants