Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support connection extra parameters in MsSqlHook #44190

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

jx2lee
Copy link
Contributor

@jx2lee jx2lee commented Nov 19, 2024

closes: #43798


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static checks fail

@jx2lee
Copy link
Contributor Author

jx2lee commented Nov 19, 2024

@shahar1 Static check was performed in different part of the code. Non-DB tests that failed are running fine locally—do I need to address something?

@jx2lee
Copy link
Contributor Author

jx2lee commented Nov 20, 2024

Need to fix test code.. change PR to draft, I'll be back to when test code finished!

@jx2lee jx2lee marked this pull request as draft November 20, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MsSql hook does not use extra parameters when creating PymssqlConnection
2 participants