Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include limit and offset in request body schema for List task instances (batch) endpoint #43479

Merged

Conversation

rawwar
Copy link
Collaborator

@rawwar rawwar commented Oct 29, 2024

Backport of #42870

…es (batch) endpoint (apache#42870)

* add offset and limit

* add offset and limit

* add offset and limit

* add tests

* add test for default offset and limit

* fix

* Update airflow/api_connexion/endpoints/task_instance_endpoint.py

Co-authored-by: Ephraim Anierobi <[email protected]>

* Update tests/api_connexion/endpoints/test_task_instance_endpoint.py

Co-authored-by: Ephraim Anierobi <[email protected]>

* fix test

---------

Co-authored-by: Ephraim Anierobi <[email protected]>
(cherry picked from commit 7b85d4e)
Signed-off-by: kalyanr <[email protected]>
@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Oct 29, 2024
@rawwar rawwar marked this pull request as ready for review October 29, 2024 14:56
@ephraimbuddy ephraimbuddy merged commit bd19bf8 into apache:v2-10-test Oct 29, 2024
48 checks passed
@rawwar rawwar deleted the kalyan/backport/add_offset_limit_ti2 branch October 29, 2024 14:59
@utkarsharma2 utkarsharma2 added the type:bug-fix Changelog: Bug Fixes label Nov 1, 2024
utkarsharma2 pushed a commit that referenced this pull request Nov 1, 2024
…es (batch) endpoint (#43479)

* include limit and offset in request body schema for List task instances (batch) endpoint  (#42870)

* add offset and limit

* add offset and limit

* add offset and limit

* add tests

* add test for default offset and limit

* fix

* Update airflow/api_connexion/endpoints/task_instance_endpoint.py

Co-authored-by: Ephraim Anierobi <[email protected]>

* Update tests/api_connexion/endpoints/test_task_instance_endpoint.py

Co-authored-by: Ephraim Anierobi <[email protected]>

* fix test

---------

Co-authored-by: Ephraim Anierobi <[email protected]>
(cherry picked from commit 7b85d4e)
Signed-off-by: kalyanr <[email protected]>

* remove spaces

---------

Signed-off-by: kalyanr <[email protected]>
Co-authored-by: Ephraim Anierobi <[email protected]>
(cherry picked from commit bd19bf8)
utkarsharma2 pushed a commit that referenced this pull request Nov 1, 2024
…es (batch) endpoint (#43479)

* include limit and offset in request body schema for List task instances (batch) endpoint  (#42870)

* add offset and limit

* add offset and limit

* add offset and limit

* add tests

* add test for default offset and limit

* fix

* Update airflow/api_connexion/endpoints/task_instance_endpoint.py

Co-authored-by: Ephraim Anierobi <[email protected]>

* Update tests/api_connexion/endpoints/test_task_instance_endpoint.py

Co-authored-by: Ephraim Anierobi <[email protected]>

* fix test

---------

Co-authored-by: Ephraim Anierobi <[email protected]>
(cherry picked from commit 7b85d4e)
Signed-off-by: kalyanr <[email protected]>

* remove spaces

---------

Signed-off-by: kalyanr <[email protected]>
Co-authored-by: Ephraim Anierobi <[email protected]>
(cherry picked from commit bd19bf8)
utkarsharma2 pushed a commit that referenced this pull request Nov 1, 2024
…es (batch) endpoint (#43479)

* include limit and offset in request body schema for List task instances (batch) endpoint  (#42870)

* add offset and limit

* add offset and limit

* add offset and limit

* add tests

* add test for default offset and limit

* fix

* Update airflow/api_connexion/endpoints/task_instance_endpoint.py

Co-authored-by: Ephraim Anierobi <[email protected]>

* Update tests/api_connexion/endpoints/test_task_instance_endpoint.py

Co-authored-by: Ephraim Anierobi <[email protected]>

* fix test

---------

Co-authored-by: Ephraim Anierobi <[email protected]>
(cherry picked from commit 7b85d4e)
Signed-off-by: kalyanr <[email protected]>

* remove spaces

---------

Signed-off-by: kalyanr <[email protected]>
Co-authored-by: Ephraim Anierobi <[email protected]>
(cherry picked from commit bd19bf8)
utkarsharma2 pushed a commit that referenced this pull request Nov 1, 2024
…es (batch) endpoint (#43479)

* include limit and offset in request body schema for List task instances (batch) endpoint  (#42870)

* add offset and limit

* add offset and limit

* add offset and limit

* add tests

* add test for default offset and limit

* fix

* Update airflow/api_connexion/endpoints/task_instance_endpoint.py

Co-authored-by: Ephraim Anierobi <[email protected]>

* Update tests/api_connexion/endpoints/test_task_instance_endpoint.py

Co-authored-by: Ephraim Anierobi <[email protected]>

* fix test

---------

Co-authored-by: Ephraim Anierobi <[email protected]>
(cherry picked from commit 7b85d4e)
Signed-off-by: kalyanr <[email protected]>

* remove spaces

---------

Signed-off-by: kalyanr <[email protected]>
Co-authored-by: Ephraim Anierobi <[email protected]>
(cherry picked from commit bd19bf8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants