Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unicodecsv dependency for providers with Airflow version 2.8.… #42970

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Oct 13, 2024

…0 and above (#42765)

(cherry picked from commit 00b8452)


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member Author

potiuk commented Oct 13, 2024

Cherry-picking #42765 - unicodecsv is a really old dependency that has been removed from few of our providers some time ago and we really should not have it in airflow - but we had to add it for back-compatibility. It's highest time to remove it also in 2.10 branch.

@potiuk
Copy link
Member Author

potiuk commented Oct 13, 2024

Should be rebased after #42977 backport for looker/kiota has been merged.

@potiuk
Copy link
Member Author

potiuk commented Oct 13, 2024

Also related discussion #42969

@potiuk
Copy link
Member Author

potiuk commented Oct 14, 2024

Ready to be merged in v2-10-test

@potiuk potiuk merged commit bdb89d3 into apache:v2-10-test Oct 15, 2024
100 checks passed
@potiuk potiuk deleted the remove-unicodecsv branch October 15, 2024 02:46
@utkarsharma2 utkarsharma2 added this to the Airflow 2.10.3 milestone Oct 23, 2024
@utkarsharma2 utkarsharma2 added the type:misc/internal Changelog: Misc changes that should appear in change log label Oct 23, 2024
utkarsharma2 pushed a commit that referenced this pull request Oct 23, 2024
…0 and above (#42765) (#42970)

(cherry picked from commit 00b8452)

Co-authored-by: Gopal Dirisala <[email protected]>
utkarsharma2 pushed a commit that referenced this pull request Oct 24, 2024
…0 and above (#42765) (#42970)

(cherry picked from commit 00b8452)

Co-authored-by: Gopal Dirisala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants