Max active tasks to be evaluated per dag run #42953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
dstandish
force-pushed
the
max-active-tasks-evaluated-per-dag-run
branch
from
db653aa
to
8986cb1
Compare
dstandish
requested review from
ephraimbuddy,
jedcunningham,
uranusjr and
Lee-W
Lee-W
reviewed
Oct 17, 2024
This behavior change was accepted by lazy consensus here: https://lists.apache.org/thread/9o84d3yn934m32gtlpokpwtbbmtxj47l. Previously max_active_tasks was evaluated across all runs of a dag.
Co-authored-by: Wei Lee <[email protected]>
Co-authored-by: Wei Lee <[email protected]>
Co-authored-by: Wei Lee <[email protected]>
dstandish
force-pushed
the
max-active-tasks-evaluated-per-dag-run
branch
from
f83bdc9
to
dd8cdbc
Compare
ashb
approved these changes
Oct 17, 2024
ephraimbuddy
approved these changes
Oct 17, 2024
|
Should the config change to |
You know it was unspecified before, and remains unspecified now. Personally, I like the brevity of it how it is. I feel when the params are super long it's harder to understand and worse user experience. Of course the question of naming can be revisited between now and 3.0 |
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
This behavior change was accepted by lazy consensus here: https://lists.apache.org/thread/9o84d3yn934m32gtlpokpwtbbmtxj47l. Previously max_active_tasks was evaluated across all runs of a dag. Co-authored-by: Wei Lee <[email protected]>
PaulKobow7536
pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
This behavior change was accepted by lazy consensus here: https://lists.apache.org/thread/9o84d3yn934m32gtlpokpwtbbmtxj47l. Previously max_active_tasks was evaluated across all runs of a dag. Co-authored-by: Wei Lee <[email protected]>
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
This behavior change was accepted by lazy consensus here: https://lists.apache.org/thread/9o84d3yn934m32gtlpokpwtbbmtxj47l. Previously max_active_tasks was evaluated across all runs of a dag. Co-authored-by: Wei Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pursuant to mailing list vote, this PR changes meaning of DAG.max_active_tasks from "per dag" to "per dag run"
Vote thread: https://lists.apache.org/thread/9o84d3yn934m32gtlpokpwtbbmtxj47l