Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated Chainable type from BaseOperator #42776

Merged
merged 8 commits into from
Oct 15, 2024

Conversation

dirrao
Copy link
Contributor

@dirrao dirrao commented Oct 6, 2024

Removed deprecated Chainable type from BaseOperator

@dirrao dirrao requested a review from uranusjr as a code owner October 6, 2024 04:16
@dirrao dirrao requested review from potiuk and eladkal October 6, 2024 04:36
@uranusjr
Copy link
Member

uranusjr commented Oct 7, 2024

We should also remove this word from spelling_wordlist.txt.

Also, apparently we forgot to actually deprecate this, so we’ll need an additional PR to add the deprecation warning to the 2.x branch.

@dirrao
Copy link
Contributor Author

dirrao commented Oct 7, 2024

We should also remove this word from spelling_wordlist.txt.

Done

Also, apparently we forgot to actually deprecate this, so we’ll need an additional PR to add the deprecation warning to the 2.x branch.

Make sense. we will create new PR for the same.

@shahar1 shahar1 added airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes area:core-operators Operators, Sensors and hooks within Core Airflow airflow3.0:candidate Potential candidates for Airflow 3.0 labels Oct 7, 2024
Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change, please add a newsfragment :)

@dirrao dirrao self-assigned this Oct 8, 2024
@dirrao
Copy link
Contributor Author

dirrao commented Oct 9, 2024

Breaking change, please add a newsfragment :)

Done.

@dirrao dirrao requested a review from shahar1 October 10, 2024 10:16
@potiuk potiuk merged commit 272cd9a into apache:main Oct 15, 2024
50 of 51 checks passed
R7L208 pushed a commit to R7L208/airflow that referenced this pull request Oct 17, 2024
* Removed deprecated Chainable type from BaseOperator

* Chainable word removed from spelling_wordlist.txt

* Chainable word removed from spelling_wordlist.txt

* Chainable word removed from spelling_wordlist.txt

* news fragment added
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
* Removed deprecated Chainable type from BaseOperator

* Chainable word removed from spelling_wordlist.txt

* Chainable word removed from spelling_wordlist.txt

* Chainable word removed from spelling_wordlist.txt

* news fragment added
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
* Removed deprecated Chainable type from BaseOperator

* Chainable word removed from spelling_wordlist.txt

* Chainable word removed from spelling_wordlist.txt

* Chainable word removed from spelling_wordlist.txt

* news fragment added
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
* Removed deprecated Chainable type from BaseOperator

* Chainable word removed from spelling_wordlist.txt

* Chainable word removed from spelling_wordlist.txt

* Chainable word removed from spelling_wordlist.txt

* news fragment added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes airflow3.0:candidate Potential candidates for Airflow 3.0 area:core-operators Operators, Sensors and hooks within Core Airflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants