-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated SubDags #41390
Remove deprecated SubDags #41390
Conversation
64046c6
to
13118d0
Compare
e535d08
to
903b20c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concerning the root_dag_id, I guess security/permissions.py
should also be updated but then, I think Airflow 3 might no longer be compatible with current providers.
Yeah, that is mainly to be handled on the Auth provider implementation rather than core Airflow so it works for Airflow 2 & Airflow 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll also need to remove docs/apache-airflow/img/subdag_after.png , docs/apache-airflow/img/subdag_before.png and docs/apache-airflow/img/subdag_zoom.png
Done, removed |
Oh, in numer of LoC removed as PR this is a high chance to get PR of the month :-D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much complexity removed ... Good job.
This PR removes SubDags in favor of TaskGroups fro Airflow 3.0 Subdags have been removed from the following locations: - CLI - API - ``SubDagOperator`` This removal marks the end of Subdag support across all interfaces. Users should transition to using TaskGroups as a more efficient and maintainable alternative. --------- Co-authored-by: Brent Bovenzi <[email protected]>
This PR removes SubDags in favor of TaskGroups fro Airflow 3.0 Subdags have been removed from the following locations: - CLI - API - ``SubDagOperator`` This removal marks the end of Subdag support across all interfaces. Users should transition to using TaskGroups as a more efficient and maintainable alternative. --------- Co-authored-by: Brent Bovenzi <[email protected]>
Was missed in apache#41390
This PR removes SubDags in favor of TaskGroups fro Airflow 3.0
Subdags have been removed from the following locations:
SubDagOperator
This removal marks the end of Subdag support across all interfaces. Users should transition to using TaskGroups as a more efficient and maintainable alternative.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.