Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RAW HTML support from Trigger Form UI #40029

Merged

Conversation

jscheffl
Copy link
Contributor

@jscheffl jscheffl commented Jun 3, 2024

As follow-up of PR #35460 I propose to remove RAW HTML form support in Airflow 2.10. It was deprecated in 2.8 as of raised security concerns allowing to inject JavaScript into client browser.

You could treat it as "breaking change", following the announced deprecation in 2.8 I would judge it as "anti feature" and therefore can be considered as cleanup / feature release.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues kind:documentation labels Jun 3, 2024
@jscheffl jscheffl added this to the Airflow 2.10.0 milestone Jun 3, 2024
@jedcunningham
Copy link
Member

I'm generally against this given how we currently handle deprecations - this is a breaking change for those users, and those using it today have already accepted the security risks.

Unless we want to define a policy where we remove deprecated features generally after x time/releases/something, I don't think it's appropriate to remove it from Airflow 2. We have a ton of deprecated features (cough subdags cough) that would meet this "anti feature" bar that we can't remove.

@potiuk
Copy link
Member

potiuk commented Jun 4, 2024

I'm generally against this given how we currently handle deprecations - this is a breaking change for those users, and those using it today have already accepted the security risks.

Unless we want to define a policy where we remove deprecated features generally after x time/releases/something, I don't think it's appropriate to remove it from Airflow 2. We have a ton of deprecated features (cough subdags cough) that would meet this "anti feature" bar that we can't remove.

Agree. We should remove it in Airlfow 3.

@jscheffl jscheffl modified the milestones: Airflow 2.10.0, Airflow 3.0.0 Jun 4, 2024
@jscheffl
Copy link
Contributor Author

jscheffl commented Jun 4, 2024

Okay, then I'll try to keep this PR in memory until we have an AF3 branch to clean-up

@jscheffl jscheffl closed this Jun 4, 2024
@jscheffl
Copy link
Contributor Author

As plans for Airflow 3 are around the corner... re-open to have a first cleanup mergeable after new development branch is ready :-D

@jscheffl jscheffl reopened this Jul 17, 2024
@kaxil kaxil added the airflow3.0:candidate Potential candidates for Airflow 3.0 label Jul 31, 2024
@jscheffl jscheffl force-pushed the feature/remove-trigger-form-support-for-raw-html branch from ac9b685 to ad28ac0 Compare August 20, 2024 12:17
@jscheffl jscheffl added airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes and removed airflow3.0:candidate Potential candidates for Airflow 3.0 labels Aug 20, 2024
@jscheffl jscheffl force-pushed the feature/remove-trigger-form-support-for-raw-html branch from d02ca32 to f45006e Compare August 20, 2024 13:29
@jscheffl jscheffl force-pushed the feature/remove-trigger-form-support-for-raw-html branch from f45006e to fe207d5 Compare August 20, 2024 21:53
@jscheffl jscheffl merged commit 23e9716 into apache:main Aug 21, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues kind:documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants