-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove RAW HTML support from Trigger Form UI #40029
Remove RAW HTML support from Trigger Form UI #40029
Conversation
I'm generally against this given how we currently handle deprecations - this is a breaking change for those users, and those using it today have already accepted the security risks. Unless we want to define a policy where we remove deprecated features generally after x time/releases/something, I don't think it's appropriate to remove it from Airflow 2. We have a ton of deprecated features (cough subdags cough) that would meet this "anti feature" bar that we can't remove. |
Agree. We should remove it in Airlfow 3. |
Okay, then I'll try to keep this PR in memory until we have an AF3 branch to clean-up |
As plans for Airflow 3 are around the corner... re-open to have a first cleanup mergeable after new development branch is ready :-D |
ac9b685
to
ad28ac0
Compare
d02ca32
to
f45006e
Compare
f45006e
to
fe207d5
Compare
As follow-up of PR #35460 I propose to remove RAW HTML form support in Airflow 2.10. It was deprecated in 2.8 as of raised security concerns allowing to inject JavaScript into client browser.
You could treat it as "breaking change", following the announced deprecation in 2.8 I would judge it as "anti feature" and therefore can be considered as cleanup / feature release.