-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can update RenderedTaskInstanceFields over RPC #38565
Merged
dstandish
merged 3 commits into
apache:main
from
astronomer:can-update-renderedtaskinstancefields-over-rpc
Apr 2, 2024
Merged
Can update RenderedTaskInstanceFields over RPC #38565
dstandish
merged 3 commits into
apache:main
from
astronomer:can-update-renderedtaskinstancefields-over-rpc
Apr 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
commented
Mar 27, 2024
uranusjr
reviewed
Apr 2, 2024
potiuk
approved these changes
Apr 2, 2024
dstandish
force-pushed
the
can-update-renderedtaskinstancefields-over-rpc
branch
from
April 2, 2024 15:54
60d3ebf
to
11c4f5c
Compare
dstandish
force-pushed
the
can-update-renderedtaskinstancefields-over-rpc
branch
from
April 2, 2024 16:29
6805e92
to
753f55c
Compare
ephraimbuddy
added
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
AIP-44
Airflow Internal API
labels
Jun 3, 2024
ephraimbuddy
added a commit
to astronomer/airflow
that referenced
this pull request
Oct 14, 2024
Previously, this was how it was done, but now, a session was used for both the writing and deletion of RTIF, which we suspect caused StaleDataError. The related PR: apache#38565 This PR brings back the old behaviour of using different sessions for writing/deleting RTIFs
ephraimbuddy
added a commit
that referenced
this pull request
Oct 14, 2024
* Use different sessions in writing and deletion of RTIF Previously, this was how it was done, but now, a session was used for both the writing and deletion of RTIF, which we suspect caused StaleDataError. The related PR: #38565 This PR brings back the old behaviour of using different sessions for writing/deleting RTIFs * fixup! Use different sessions in writing and deletion of RTIF * add test and use flush
ephraimbuddy
added a commit
to astronomer/airflow
that referenced
this pull request
Oct 14, 2024
* FLush the session before deleting the RTIF data Previously, this was how it was done, but now, a session was used for both the writing and deletion of RTIF, which we suspect caused StaleDataError. The related PR: apache#38565 This PR brings back the old behaviour of using different sessions for writing/deleting RTIFs * fixup! Use different sessions in writing and deletion of RTIF * add test and use flush (cherry picked from commit ced319f)
ephraimbuddy
added a commit
that referenced
this pull request
Oct 14, 2024
* FLush the session before deleting the RTIF data Previously, this was how it was done, but now, a session was used for both the writing and deletion of RTIF, which we suspect caused StaleDataError. The related PR: #38565 This PR brings back the old behaviour of using different sessions for writing/deleting RTIFs * fixup! Use different sessions in writing and deletion of RTIF * add test and use flush (cherry picked from commit ced319f)
R7L208
pushed a commit
to R7L208/airflow
that referenced
this pull request
Oct 17, 2024
* Use different sessions in writing and deletion of RTIF Previously, this was how it was done, but now, a session was used for both the writing and deletion of RTIF, which we suspect caused StaleDataError. The related PR: apache#38565 This PR brings back the old behaviour of using different sessions for writing/deleting RTIFs * fixup! Use different sessions in writing and deletion of RTIF * add test and use flush
utkarsharma2
pushed a commit
that referenced
this pull request
Oct 23, 2024
* FLush the session before deleting the RTIF data Previously, this was how it was done, but now, a session was used for both the writing and deletion of RTIF, which we suspect caused StaleDataError. The related PR: #38565 This PR brings back the old behaviour of using different sessions for writing/deleting RTIFs * fixup! Use different sessions in writing and deletion of RTIF * add test and use flush (cherry picked from commit ced319f)
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
* Use different sessions in writing and deletion of RTIF Previously, this was how it was done, but now, a session was used for both the writing and deletion of RTIF, which we suspect caused StaleDataError. The related PR: apache#38565 This PR brings back the old behaviour of using different sessions for writing/deleting RTIFs * fixup! Use different sessions in writing and deletion of RTIF * add test and use flush
PaulKobow7536
pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
* Use different sessions in writing and deletion of RTIF Previously, this was how it was done, but now, a session was used for both the writing and deletion of RTIF, which we suspect caused StaleDataError. The related PR: apache#38565 This PR brings back the old behaviour of using different sessions for writing/deleting RTIFs * fixup! Use different sessions in writing and deletion of RTIF * add test and use flush
utkarsharma2
pushed a commit
that referenced
this pull request
Oct 24, 2024
* FLush the session before deleting the RTIF data Previously, this was how it was done, but now, a session was used for both the writing and deletion of RTIF, which we suspect caused StaleDataError. The related PR: #38565 This PR brings back the old behaviour of using different sessions for writing/deleting RTIFs * fixup! Use different sessions in writing and deletion of RTIF * add test and use flush (cherry picked from commit ced319f)
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* Use different sessions in writing and deletion of RTIF Previously, this was how it was done, but now, a session was used for both the writing and deletion of RTIF, which we suspect caused StaleDataError. The related PR: apache#38565 This PR brings back the old behaviour of using different sessions for writing/deleting RTIFs * fixup! Use different sessions in writing and deletion of RTIF * add test and use flush
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
AIP-44
Airflow Internal API
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.