-
Notifications
You must be signed in to change notification settings - Fork 17.3k
Revoking audit_log permission from all users except admin #37501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+22
−3
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1059ee3
Revoking audit_log permission from viewer role
amoghrajesh 437285e
moving revoked permissions to USER_PERMISSIONS for other users
amoghrajesh 82e416d
audit logs only on admins
amoghrajesh fcf1cd5
review comments by Jed
amoghrajesh c381759
review comments from Jed
amoghrajesh 1cb1958
adding a newsfragment
amoghrajesh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| The audit_logs permissions have been updated for heightened security. | ||
|
|
||
| This was done under the policy that we do not want users like Viewer, Ops, | ||
| and other users apart from Admin to have access to audit_logs. The intention behind | ||
| this change is to restrict users with less permissions from viewing user details | ||
| like First Name, Email etc. from the audit_logs when they are not permitted to. | ||
|
|
||
| The impact of this change is that the existing users with non admin rights won't be able | ||
| to view or access the audit_logs, both from the Browse tab or from the DAG run. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.