Use dropdown instead of buttons when there are more than 10 retries in log tab#36025
Merged
Conversation
jscheffl
reviewed
Dec 2, 2023
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
eladkal
approved these changes
Dec 2, 2023
jscheffl
approved these changes
Dec 2, 2023
potiuk
approved these changes
Dec 3, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Dec 5, 2023
…n log tab (#36025) * Use dropdown instead of buttons when there are more than 10 retries in log tab. * Update airflow/www/static/js/dag/details/taskInstance/Logs/index.tsx Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> --------- Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> (cherry picked from commit fd09883)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use dropdown instead of button to select log attempt when there are more than 10 retries.
Less than 10 retries
More than 10 retries
closes: #35889
related: #35889
Sample dag :