Consolidate the call of change_state to fail or success in the core executors#35901
Merged
hussein-awala merged 2 commits intoNov 28, 2023
Merged
Conversation
hussein-awala
requested review from
XD-DENG,
ashb,
kaxil,
o-nikolas and
pierrejeambrun
as code owners
boring-cyborg
Bot
added
the
area:Executors-core
o-nikolas
reviewed
Nov 27, 2023
o-nikolas
left a comment
o-nikolas
left a comment
Contributor
There was a problem hiding this comment.
src changes look good but tests need to be updated to mock patch fail/success instead of change_state
hussein-awala
force-pushed
the
consolidate_executors_change_state
branch
from
6359911 to
d6ea9a8
Compare
Member
Author
|
It should be ok now! |
o-nikolas
approved these changes
Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
fail(...)/sucess(...)instead ofchange_state(..., TaskInstanceState.FAILED/change_state(..., TaskInstanceState. SUCCESSin the core executors.