Rename Connection.to_json_dict to Connection.to_dict#35894
Merged
Conversation
Taragolis
requested review from
XD-DENG,
ashb,
bolkedebruin and
kaxil
as code owners
Taragolis
force-pushed
the
to-json-dict-rename
branch
from
9b33dad to
b152835
Compare
dstandish
approved these changes
Nov 27, 2023
potiuk
approved these changes
Nov 29, 2023
eladkal
added
the
type:misc/internal
eladkal
approved these changes
Nov 30, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Dec 5, 2023
(cherry picked from commit 7594b7a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of slack discussion: https://apache-airflow.slack.com/archives/CCPRP7943/p1701099077963059
to_dictwas added in AIP-44 Migrate MetastoreBackend to Internal API #33829, this is undocumented method only use for serialisation. Assumption: this is private method.to_json_dictwas added in Implements JSON-string connection representation generator #35723, as replacement forto_dictthe main different between this methods thatto_json_dictsave fields as is in opposite ofto_dictwhich serialise methods to URI representation of connection. Private methodSo if both of them are private and do same thing, but slightly different way, we could merge it into the single one.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.