-
Notifications
You must be signed in to change notification settings - Fork 17.3k
Implements JSON-string connection representation generator #35723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -498,7 +498,7 @@ def serialize( | |
| type_=DAT.SIMPLE_TASK_INSTANCE, | ||
| ) | ||
| elif isinstance(var, Connection): | ||
| return cls._encode(var.to_dict(), type_=DAT.CONNECTION) | ||
| return cls._encode(var.to_json_dict(validate=True), type_=DAT.CONNECTION) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Isn't that going to be backwards incompatible for older connections?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It should be backward compatible. I'm also not sure that we ever serialize connection in Airflow.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Previous version serialize conn_id, description and uri new one every field except uri. So this is basically two existed ways to create connection from constructor. |
||
| elif use_pydantic_models and _ENABLE_AIP_44: | ||
|
|
||
| def _pydantic_model_dump(model_cls: type[BaseModel], var: Any) -> dict[str, Any]: | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.