Skip to content

Increase timeouts for flaky daskexecutor test #35473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Nov 6, 2023
Merged

Increase timeouts for flaky daskexecutor test #35473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/providers/daskexecutor/test_dask_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,7 @@ def test_dask_queues(self):
assert success_future.done()
assert success_future.exception() is None

@pytest.mark.execution_timeout(120)
def test_dask_queues_no_queue_specified(self):
self.cluster = LocalCluster(resources={"queue1": 1})
executor = DaskExecutor(cluster_address=self.cluster.scheduler_address)
Expand All @@ -224,7 +225,7 @@ def test_dask_queues_no_queue_specified(self):
success_future = next(k for k, v in executor.futures.items() if v == "success")

# wait for the futures to execute, with a timeout
timeout = timezone.utcnow() + timedelta(seconds=30)
timeout = timezone.utcnow() + timedelta(seconds=100)
while not success_future.done():
if timezone.utcnow() > timeout:
raise ValueError(
Expand Down