Fix test to test if we miss tests (AKA 'who tests the tests') #35443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test aimed to make sure that we add tests when we add modules ... But it seems it's been broken for a while and generally it expected no tests at all and never complained (Who tests the tests?) The root cause was generous (pun intended) use of generators - simply speaking when generator gets iterated over, the second time it gets iterated, it returns ... nothing ... These list are not really huge so using generators here has been largely premature optmisation that makes it also difficult to debug, for now I converted it to use lists - debugging of lists is way easier too. We have the list of tests now that we should add and they are captured in the issue apache#35442
eladkal
approved these changes
Nov 4, 2023
Contributor
Yeah, for a long time: #28459 (comment) |
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
…#35443) This test aimed to make sure that we add tests when we add modules ... But it seems it's been broken for a while and generally it expected no tests at all and never complained (Who tests the tests?) The root cause was generous (pun intended) use of generators - simply speaking when generator gets iterated over, the second time it gets iterated, it returns ... nothing ... These list are not really huge so using generators here has been largely premature optmisation that makes it also difficult to debug, for now I converted it to use lists - debugging of lists is way easier too. We have the list of tests now that we should add and they are captured in the issue apache#35442
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test aimed to make sure that we add tests when we add modules ...
But it seems it's been broken for a while and generally it expected no tests at all and never complained (Who tests the tests?)
The root cause was generous (pun intended) use of generators - simply speaking when generator gets iterated over, the second time it gets iterated, it returns ... nothing ...
These list are not really huge so using generators here has been largely premature optmisation that makes it also difficult to debug, for now I converted it to use lists - debugging of lists is way easier too.
We have the list of tests now that we should add and they are captured in the issue #35442
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.