Add multiselect to run state in grid view#35403
Conversation
vchiapaikeo
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
Bot
added
area:UI
vchiapaikeo
force-pushed
the
vchiapaikeo/k8s-cncf-check-v3
branch
2 times, most recently
from
0897dd3 to
b7f5db6
Compare
|
Nice. I wonder if listing all of the options by default is the best UX, vs leaving it empty and showing all states. |
|
Yes, good point. I could even sub it for something like "All Run States". Will get a demo out showing that as well. Also, what do you think about doing the same for run types? And are you okay with the way it is serialized as a csv with the bulk of the manipulation logic on the JSX side? |
"All run states" sounds great. Let's do both run state and run type. I think the logic in the PR now looks good. |
vchiapaikeo
force-pushed
the
vchiapaikeo/k8s-cncf-check-v3
branch
from
b7f5db6 to
b939ef4
Compare
|
Great. Still need to do some work on tests. |
vchiapaikeo
force-pushed
the
vchiapaikeo/k8s-cncf-check-v3
branch
from
b939ef4 to
7ef33e0
Compare
|
Latest demo: multiselect-demo2.mov |
|
Nice! |
vchiapaikeo
force-pushed
the
vchiapaikeo/k8s-cncf-check-v3
branch
from
b77aa83 to
b98dfca
Compare
|
cc @bbovenzi can we merge? |
vchiapaikeo
force-pushed
the
vchiapaikeo/k8s-cncf-check-v3
branch
from
0fa54a4 to
2a4d949
Compare
|
Latest demo: multiselect.mov |
|
I think we are good to merge here. |
vchiapaikeo
force-pushed
the
vchiapaikeo/k8s-cncf-check-v3
branch
from
2a4d949 to
777580f
Compare
|
Nice, thank you! |
* Add multiselect to run state in grid view * Fix tests * Multiselect for run types, UI nits, refactor * Fix tests, refactor * Simplify multiselect value * Nits and refactor * Use arrays instead of serializing to csv * Fix tests and global axios paramsSerializer to null (cherry picked from commit 9e28475)
5 participants
closes: #34795
multi-select-grid-view.mov
test-search-params.mov
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.