Prevent assignment of non JSON serializable values to DagRun.conf dict

[PashkPashk]

Closes #35095

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
• Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[jscheffl]

This looks good. Thanks for the contribution.

I was thinging (but have no strong opinion) as whether it makes sense to extract this to a utility, but keeping it here might be acceptable.

Can you please add a unit test for the new code which validates a positive and negative case as well?

[eladkal]

Can you please add a unit test for the new code which validates a positive and negative case as well?

yes unit test is required here

[PashkPashk]

This looks good. Thanks for the contribution.

I was thinging (but have no strong opinion) as whether it makes sense to extract this to a utility, but keeping it here might be acceptable.

Can you please add a unit test for the new code which validates a positive and negative case as well?

Could you, please, advise me where I should add this test?

airflow/tests/api_connexion/schemas/test_dag_run_schema.py

Line 49 in ef497bc

class TestDAGRunSchema(TestDAGRunBase):

This module?

[jscheffl]

This looks good. Thanks for the contribution.
I was thinging (but have no strong opinion) as whether it makes sense to extract this to a utility, but keeping it here might be acceptable.
Can you please add a unit test for the new code which validates a positive and negative case as well?

Could you, please, advise me where I should add this test?

If you implement code in airflow/models/dagrun.py then associated tests should be in tests/models/test_dagrun.py.

[jscheffl]

There are some (simple) static code check problems. Before making an approval review I'd like see them fixed. But "okay" from my side. I am not an expert in sqlachemy so I am a bit afraid from the previous review comment from @uranusjr - can you maybe double check this? Of course we need to prevent a migration for this.

[PashkPashk]

I’ve been mistaken about hybrid_property, cause it doesn’t work correctly with mypy, should be using declared_attr instead.
I'm also not really sure how to deal with test_serialize check in test_dag_run_schema, so I've added some to the init function within the last commit.
Should be ok now.

[jscheffl]

Just small glitches in static code checks. If you remove them I assume it is good to get it merged.

[jscheffl]

Still no luck with static checks, can you take a look here? Actually it just seems you need to run it once and commit the changed applied from ruff: https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst

[PashkPashk]

@jscheffl
Oops, I thought it has been applied automatically.
Fixed, I hope will work this time

[boring-cyborg]

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.