Skip to content

feat(ui/graph): enhance task status visibility#34486

Merged
hussein-awala merged 6 commits into
apache:mainfrom
hainenber:increase-task-visibility-in-graph-view
Sep 25, 2023
Merged

feat(ui/graph): enhance task status visibility#34486
hussein-awala merged 6 commits into
apache:mainfrom
hainenber:increase-task-visibility-in-graph-view

Conversation

@hainenber

@hainenber hainenber commented Sep 19, 2023

Copy link
Copy Markdown
Contributor

Closes #34455

Enhance DAG's task visibility by adding border color to task's node and increase size for task's status note.

UI change

Before
Screenshot 2023-09-20 at 21 50 28

After
Screenshot 2023-09-20 at 00 02 03


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg Bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues kind:documentation labels Sep 19, 2023
@bbovenzi

Copy link
Copy Markdown
Contributor

Thanks @hainenber Could you provide some before and after screenshots?

@hainenber hainenber force-pushed the increase-task-visibility-in-graph-view branch from 02d1e40 to 50ceb98 Compare September 20, 2023 15:00
@hainenber

Copy link
Copy Markdown
Contributor Author

@bbovenzi thanks for the review! I've provided the screenshots in the PR's description and also fixed the linting issue caught during CI

@hussein-awala hussein-awala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread airflow/www/static/js/dag/details/graph/Node.tsx Outdated
@bbovenzi

Copy link
Copy Markdown
Contributor

I'm still a bit stuck on the border color signifying two different things, task state and if its selected. And when I have a selected node, it would become less clear what the status is.

One possibility: Don't change the border color on selection, but instead change the node background?

Comment thread airflow/www/static/js/dag/details/graph/Node.tsx Outdated
@hainenber

Copy link
Copy Markdown
Contributor Author

I think your proposal works pretty fine. I've made a draft change and the selected task looks identifiable re: its status here. Do let me know what you think

Screenshot 2023-09-21 at 23 36 13

@hainenber hainenber force-pushed the increase-task-visibility-in-graph-view branch from c77b103 to 9be5ca8 Compare September 21, 2023 16:51
@hainenber

Copy link
Copy Markdown
Contributor Author

@bbovenzi does this look good to you? 👀 Sorry if it appears I'm nagging you.

@bbovenzi

Copy link
Copy Markdown
Contributor

@hainenber much better! One final piece, let's make the border width bigger if the task is selected. and then we can merge this

@hainenber

Copy link
Copy Markdown
Contributor Author

Done enlarging node's border when selected. Kindly PTAL

Screenshot 2023-09-25 at 23 39 09

@bbovenzi bbovenzi added this to the Airflow 2.7.2 milestone Sep 25, 2023
@hussein-awala hussein-awala merged commit d0ae60f into apache:main Sep 25, 2023
@boring-cyborg

boring-cyborg Bot commented Sep 25, 2023

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues kind:documentation type:improvement Changelog: Improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Graph view task name & status visibility

4 participants