Remove generic trigger cancelled error log #33874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We tried to address apache#31720 in PR apache#31757. The issue talked about adding a trigger cancelled log when trigger timesout, but we also added a generic Trigger canceled log. This log appears even in successful runs of the triggers when they finish. This is confusing some users as the log level is Error and there are sometimes quite a few log lines saying "Trigger cancelled; err=" with giving no clue as to what is happening. So, I am removing this generic error log line and we can add specific cancel scenarios with detailed reasons when we implement those.
boring-cyborg
bot
added
area:Scheduler
Member
Author
|
Noisy (& confusing) logs as reported by an user. 
|
pankajkoti
requested review from
Lee-W,
dstandish,
ephraimbuddy,
jedcunningham,
o-nikolas,
phanikumv,
potiuk and
uranusjr
Member
|
We should first have an open issue to track implementing a replacement log message. |
uranusjr
approved these changes
Aug 29, 2023
uranusjr
requested review from
XD-DENG,
ashb and
kaxil
and removed request for
Lee-W,
XD-DENG,
ashb,
dstandish,
ephraimbuddy,
jedcunningham,
kaxil,
o-nikolas,
phanikumv and
potiuk
Member
Yep. |
potiuk
approved these changes
Aug 29, 2023
Lee-W
approved these changes
Aug 29, 2023
2 tasks
Member
Author
yes, thank you. Created an issue #33877 |
uranusjr
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tried to address #31720 in PR #31757. The issue talked
about adding a trigger cancelled log when trigger times out,
but we also added a generic Trigger canceled log. This log
appears even in successful runs of the triggers when they
finish. This is confusing some users as the log level is Error
and there are sometimes quite a few log lines saying
"Trigger cancelled; message=" with giving no clue as to what is
happening. So, I am removing this generic error log line and
we can later add specific cancel scenarios with detailed
reasons when we implement those.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.