build(pre-commit): check deferrable default value #32370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
looks good :). Let's see how it works :) |
Lee-W
force-pushed
the
pre-commit-check-deferrable-default
branch
from
8ece00b to
78cf7e8
Compare
Lee-W
requested review from
ashb,
jedcunningham,
mik-laj and
potiuk
as code owners
Member
Author
|
@potiuk Just finished the implementation. I use it to detect 2 operators with |
Member
That was my hope that we will get something like that to test it :) |
potiuk
approved these changes
Jul 5, 2023
uranusjr
reviewed
Jul 5, 2023
vincbeck
approved these changes
Jul 5, 2023
Lee-W
force-pushed
the
pre-commit-check-deferrable-default
branch
from
47b0de9 to
1629a0f
Compare
uranusjr
force-pushed
the
pre-commit-check-deferrable-default
branch
from
5a82e9a to
cf31b57
Compare
uranusjr
approved these changes
Jul 6, 2023
Member
|
One more change to make the doc URL only appear once, not for every error detected. |
Member
|
Seems the checks are failing now :( |
…lean("operators", "default_deferrable", fallback=False),
Lee-W
force-pushed
the
pre-commit-check-deferrable-default
branch
from
73222d0 to
40430c8
Compare
Lee-W
force-pushed
the
pre-commit-check-deferrable-default
branch
from
40430c8 to
03e1174
Compare
uranusjr
force-pushed
the
pre-commit-check-deferrable-default
branch
from
89bf164 to
9463da5
Compare
potiuk
approved these changes
Jul 7, 2023
syedahsn
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jul 11, 2023
--------- Co-authored-by: Tzu-ping Chung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #31712, #32355 (comment), #29462 (review)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.