Only update crawler tags if present in config dict

[luos-fc]

Closes: #32330

This PR modifies the GlueCrawlerHook to only update the crawlers tags if the Tags key is present in the config dict. This prevent situations where tags that are set by external processes are overwritten whenever the crawler is run from Airflow.

[Adaverse]

The changes and corresponding test coverage LGTM.

[utkarsharma2]

Should we also add a testcase for when Tags key is in the config? Not sure if it's already covered.

[Adaverse]

i think test_replace_tag function is testing the above case.

[potiuk]

yeah. Can you double check it @utkarsharma2 ?

[utkarsharma2]

Ya, they are covered. I got confused by these lines, it seems like they don't add any value to the test. Test seems to work even after removing them.

airflow/tests/providers/amazon/aws/hooks/test_glue_crawler.py

Lines 169 to 170 in d012483

	mock_config_two = deepcopy(mock_config)
	mock_config_two.pop("Tags")

[luos-fc]

I removed those two lines

[Adaverse]

Can we also do this cleanup i.e in test test_replace_tag, it seems like the below code snippet is just laying there -

        mock_config_two = deepcopy(mock_config)
        mock_config_two.pop("Tags")

[potiuk]

Can we also do this cleanup i.e in test test_replace_tag, it seems like the below code snippet is just lying there -

        mock_config_two = deepcopy(mock_config)
        mock_config_two.pop("Tags")

what do you mean by lying :) ?

[Adaverse]

Can we also do this cleanup i.e in test test_replace_tag, it seems like the below code snippet is just lying there -

        mock_config_two = deepcopy(mock_config)
        mock_config_two.pop("Tags")

what do you mean by lying :) ?

The variable mock_config_two isn't being used just defined. Pardon for the typo lying :).

[Adaverse]

LGTM