aws waiter util: log status info with error level on waiter error #32247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently, the status info is not even logged on error, which is not great to debug. Rather than moving the log line above the check on error type, I think it makes sense to log at a different level to help users who'd have onfo logs disabled diagnose.
boring-cyborg
bot
added
area:providers
provider:amazon
vincbeck
reviewed
Jun 29, 2023
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, the status info is not even logged on error, which is not great to debug. Rather than moving the log line above the check on error type, I think it makes sense to log at a different level to help users who'd have info logs disabled diagnose.
realized this after reading #32151