Add ChimeNotifier
#32222
Merged
Add ChimeNotifier
#32222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
kind:documentation
provider:amazon
eladkal
reviewed
Jun 28, 2023
docs/apache-airflow-providers-amazon/notifications/chime_notifier_howto_guide.rst
Show resolved
Hide resolved
vincbeck
reviewed
Jun 28, 2023
| @@ -0,0 +1,61 @@ | |||
| # Licensed to the Apache Software Foundation (ASF) under one | |||
Contributor
There was a problem hiding this comment.
Should we name the directory notifiers instead? To be consistent with operators, hooks, ...
Contributor
Author
There was a problem hiding this comment.
Notifications was consistent with how other providers have named such as Slack and Discord. But I am open to renaming if there is consensus.
Contributor
There was a problem hiding this comment.
Lets stay with the current convention for now.
Notifiers is a new experience and I prefer to gather feedback before we start deprecating.
vincbeck
approved these changes
Jun 28, 2023
eladkal
approved these changes
Jun 28, 2023
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature:
Adding
ChimeNotifierfor Amazon provider to enable notifications to a Chime chat room via callbacks. This feature will allow a user to create notifications via a Chime webhook utlizing theChimeWebhookHookwith the message allowing templating.Example code added to How-to Guide for Chime notifications under the Amazon provider docs under notifications folder.