Skip to content

Conversation

@eladkal
Copy link
Contributor

@eladkal eladkal commented Jun 27, 2023

Reverts #32110

Fix failing main:


=========================== short test summary info ============================
FAILED tests/providers/amazon/aws/hooks/test_rds.py::TestRdsHook::test_wait_for_db_instance_state_boto_waiters - AssertionError: expected call not found.
Expected: wait(DBInstanceIdentifier='testrdshook-db-instance', WaiterConfig={'Delay': 0, 'MaxAttempts': 1})
Actual: wait(DBInstanceIdentifier='testrdshook-db-instance', WaiterConfig={'MaxAttempts': 1})

pytest introspection follows:

Kwargs:
assert {'DBInstanceI...Attempts': 1}} == {'DBInstanceI...Attempts': 1}}
  Omitting 1 identical items, use -vv to show
  Differing items:
  {'WaiterConfig': {'MaxAttempts': 1}} != {'WaiterConfig': {'Delay': 0, 'MaxAttempts': 1}}
  Full diff:
    {
     'DBInstanceIdentifier': 'testrdshook-db-instance',
  -  'WaiterConfig': {'Delay': 0, 'MaxAttempts': 1},
  ?                   ------------
  +  'WaiterConfig': {'MaxAttempts': 1},
    }
FAILED tests/providers/amazon/aws/triggers/test_athena.py::TestAthenaTrigger::test_run_success - TypeError: async_wait() got an unexpected keyword argument 'max_attempts'

Examples:
https://github.com/apache/airflow/actions/runs/5386754572/jobs/9777311585?pr=32171#step:6:4846
https://github.com/apache/airflow/actions/runs/5386754572/jobs/9777311585?pr=32171#step:6:4880

@eladkal eladkal requested a review from o-nikolas as a code owner June 27, 2023 08:19
@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Jun 27, 2023
@potiuk potiuk merged commit 3a85d4e into main Jun 27, 2023
@eladkal eladkal deleted the revert-32110-vandonr/athena branch June 27, 2023 09:34
vandonr-amz added a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jun 27, 2023
ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants