Add an option to GlueJobOperator to stop the job run when the TI is killed
#32155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…illed Signed-off-by: Hussein Awala <[email protected]>
boring-cyborg
bot
added
area:providers
provider:amazon
vincbeck
requested changes
Jun 27, 2023
Contributor
vincbeck
left a comment
vincbeck
left a comment
There was a problem hiding this comment.
A simple nit. I think glue_job can be confusing and can make you think you return the actual glue job
o-nikolas
reviewed
Jun 27, 2023
Member
Author
|
@vincbeck @o-nikolas Thank you for your suggestion. Could you please take a second look? |
o-nikolas
approved these changes
Jun 27, 2023
vincbeck
approved these changes
Jun 28, 2023
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #32137
This PR adds a new boolean parameter
stop_job_run_on_killtoGlueJobOperator, when it is set toTrue, the Glue job run will be stopped if the TI is killed (because of a timeout or a SIGTERM/clear).^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.