deferrable mode for SageMakerTuningOperator and SageMakerEndpointOperator
#32112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
area:system-tests
provider:amazon
vandonr-amz
commented
Jun 24, 2023
Comment on lines
-44
to
+45
| max_attempts: int | None = None, | ||
| max_attempts: int = 480, |
Contributor
Author
There was a problem hiding this comment.
passing None was not working before, so this is not a breaking change since it was already broken.
| cp /root/.aws/credentials /tmp/credentials && | ||
| # login to public ecr repo containing amazonlinux image | ||
| docker login --username {creds.username} --password {creds.password} public.ecr.aws | ||
| docker login --username {creds.username} --password {creds.password} public.ecr.aws && |
Contributor
Author
There was a problem hiding this comment.
the old version was working too, but at least this homogeneous with the other lines of the command
| rm /tmp/credentials && | ||
| # login again, this time to the private repo we created to hold that specific image | ||
| aws ecr get-login-password --region {ecr_region} | |
Contributor
Author
There was a problem hiding this comment.
this is probably from before, when we didn't pass credentials in the command line, but it's now useless.
| "Failed to prepare docker image for the preprocessing job.\n" | ||
| f"The following error happened while executing the sequence of bash commands:\n{stderr}" | ||
| "The following error happened while executing the sequence of bash commands:\n" | ||
| f"{stderr.decode()}" |
Contributor
Author
There was a problem hiding this comment.
stderr is a byte array. Without the decode(), the \n are not escaped for instance, and the whole output appears on one line, which is not the best
vandonr-amz
changed the title
SageMakerTuningOperatorSageMakerTuningOperator and SageMakerEndpointOperator
vandonr-amz
changed the title
SageMakerTuningOperator and SageMakerEndpointOperatorSageMakerTuningOperator and SageMakerEndpointOperator
vandonr-amz
changed the title
SageMakerTuningOperator and SageMakerEndpointOperator
vandonr-amz
changed the title
SageMakerTuningOperator and SageMakerEndpointOperator
Contributor
Author
|
TIL: when updating a PR title with |
potiuk
approved these changes
Jun 27, 2023
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
took the opportunity to fix tiny things in the system test,
and also migrate to the trigger to the method that logs the status while it waits