Add a deferrable mode to BatchCreateComputeEnvironmentOperator
#32036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
vincbeck
requested changes
Jun 20, 2023
phanikumv
reviewed
Jun 21, 2023
Contributor
phanikumv
left a comment
phanikumv
left a comment
There was a problem hiding this comment.
can you add documentation for the availability of deferrable param for this operator
Contributor
Author
do you mean in the batch.rst file ? If so, the problem is that this relies on examples from the system tests, and system tests don't support deferrables just yet (we need #31826 for that) |
vincbeck
approved these changes
Jun 27, 2023
potiuk
approved these changes
Jun 27, 2023
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This operator didn't have a wait_for_completion mode, but there is still some completion to wait for.
I'm adding a deferrable mode to it via a new custom waiter.
I'm reusing the
max_retriesparameter that was passed to the hook for no good reason, and deprecating along the way the other retry param that had no effect.cc @syedahsn