Add deferrable mode in EMR operator and sensor #32029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
Member
Author
|
cc: @syedahsn |
pankajkoti
reviewed
Jun 20, 2023
Lee-W
reviewed
Jun 21, 2023
pankajastro
force-pushed
the
add_emr_async_op
branch
from
3a0f04c to
7a398a5
Compare
phanikumv
reviewed
Jun 21, 2023
Contributor
phanikumv
left a comment
phanikumv
left a comment
There was a problem hiding this comment.
Can you add docs about availability of deferrable mode for these operators?
pankajastro
force-pushed
the
add_emr_async_op
branch
from
5d8a393 to
7f251e6
Compare
Lee-W
reviewed
Jun 23, 2023
pankajastro
force-pushed
the
add_emr_async_op
branch
from
c742abb to
dae1b39
Compare
Lee-W
approved these changes
Jun 26, 2023
phanikumv
reviewed
Jun 26, 2023
phanikumv
reviewed
Jun 26, 2023
pankajastro
requested review from
ephraimbuddy and
phanikumv
and removed request for
syedahsn
phanikumv
approved these changes
Jun 27, 2023
Contributor
phanikumv
left a comment
phanikumv
left a comment
There was a problem hiding this comment.
rebase it from main and we should be good to go!
syedahsn
reviewed
Jun 27, 2023
syedahsn
reviewed
Jun 27, 2023
syedahsn
reviewed
Jun 27, 2023
pankajastro
force-pushed
the
add_emr_async_op
branch
from
bed285f to
15413b6
Compare
Add the deferrable param in EmrContainerOperator/EmrStepSensor/EmrJobFlowSensor. This will allow running Operator/Sensors in an async way that means we only submit a job from the worker to run a job then defer to the trigger for polling and wait for a job the job status and the worker slot won't be occupied for the whole period of task execution.
pankajastro
force-pushed
the
add_emr_async_op
branch
from
b57df3b to
58e90bb
Compare
ephraimbuddy
approved these changes
Jun 27, 2023
Co-authored-by: Ephraim Anierobi <[email protected]>
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jun 27, 2023
* Add deferrable mode in EMR operator and sensor Add the deferrable param in EmrContainerOperator/EmrStepSensor/EmrJobFlowSensor. This will allow running Operator/Sensors in an async way that means we only submit a job from the worker to run a job then defer to the trigger for polling and wait for a job the job status and the worker slot won't be occupied for the whole period of task execution.
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the deferrable param in
EmrContainerOperator/EmrStepSensor/EmrJobFlowSensor.
This will allow running Operator/Sensors in an async way
which means we only submit a job from the worker to run a job
then defer to the trigger for polling and wait for a job the job status
and the worker slot won't be occupied for the whole period of task execution.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.