-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable setting ODBC driver via extra by default #31713
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajkoti
approved these changes
Jun 5, 2023
eladkal
approved these changes
Jun 5, 2023
o-nikolas
approved these changes
Jun 5, 2023
dstandish
reviewed
Jun 5, 2023
potiuk
force-pushed
the
remove-driver-extra-odbc
branch
from
June 5, 2023 21:06
33756d8
to
46799ec
Compare
potiuk
changed the title
Only allow to set driver via Hook constructor parameters
Disable setting ODBC driver via extra by default
Jun 5, 2023
By default setting driver via extra is disabled by default but we have several more ways to set it.
potiuk
force-pushed
the
remove-driver-extra-odbc
branch
from
June 5, 2023 21:06
46799ec
to
517c498
Compare
eladkal
pushed a commit
that referenced
this pull request
Jun 8, 2023
potiuk
pushed a commit
that referenced
this pull request
Jun 9, 2023
86 tasks
ahidalgob
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 7, 2023
…1754) Refines apache/airflow#31713, which disabled (by default) setting driver through extra. Here we make it so that the flag to enable is located in airflow config instead of hook param. (cherry picked from commit 438ba41e142593f2b0916893eccbd08fbe4d277b) GitOrigin-RevId: 3bbf6fd73aef62c2030b8babaacb4791c49ba04a
ahidalgob
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 15, 2024
…1754) Refines apache/airflow#31713, which disabled (by default) setting driver through extra. Here we make it so that the flag to enable is located in airflow config instead of hook param. GitOrigin-RevId: 438ba41e142593f2b0916893eccbd08fbe4d277b
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default setting driver via extra is disabled by default but we
have several more ways to set it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.