Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable setting ODBC driver via extra by default #31713

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jun 5, 2023

By default setting driver via extra is disabled by default but we
have several more ways to set it.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk changed the title Only allow to set driver via Hook constructor parameters Disable setting ODBC driver via extra by default Jun 5, 2023
By default setting driver via extra is disabled by default but we
have several more ways to set it.
@potiuk potiuk merged commit 2844dad into apache:main Jun 6, 2023
@potiuk potiuk deleted the remove-driver-extra-odbc branch June 6, 2023 11:41
dstandish added a commit that referenced this pull request Jun 7, 2023
…1754)

Refines #31713, which disabled (by default) setting driver through extra.  Here we make it so that the flag to enable is located in airflow config instead of hook param.
eladkal pushed a commit that referenced this pull request Jun 8, 2023
…1754)

Refines #31713, which disabled (by default) setting driver through extra.  Here we make it so that the flag to enable is located in airflow config instead of hook param.

(cherry picked from commit 438ba41)
potiuk pushed a commit that referenced this pull request Jun 9, 2023
…1754)

Refines #31713, which disabled (by default) setting driver through extra.  Here we make it so that the flag to enable is located in airflow config instead of hook param.

(cherry picked from commit 438ba41)
ahidalgob pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 7, 2023
…1754)

Refines apache/airflow#31713, which disabled (by default) setting driver through extra.  Here we make it so that the flag to enable is located in airflow config instead of hook param.

(cherry picked from commit 438ba41e142593f2b0916893eccbd08fbe4d277b)

GitOrigin-RevId: 3bbf6fd73aef62c2030b8babaacb4791c49ba04a
ahidalgob pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request May 15, 2024
…1754)

Refines apache/airflow#31713, which disabled (by default) setting driver through extra.  Here we make it so that the flag to enable is located in airflow config instead of hook param.

GitOrigin-RevId: 438ba41e142593f2b0916893eccbd08fbe4d277b
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants