Add deferrable mode to BeamRunPythonPipelineOperator
#31471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladaZakharova
force-pushed
the
beam-python-pipeline-def
branch
2 times, most recently
from
6103229 to
f57cc11
Compare
Contributor
Author
|
Hi @potiuk ! |
potiuk
approved these changes
Jun 8, 2023
potiuk
force-pushed
the
beam-python-pipeline-def
branch
from
f57cc11 to
3094bce
Compare
Member
|
Some docstrings need fixing as we already added D400 check for docstrings. |
VladaZakharova
force-pushed
the
beam-python-pipeline-def
branch
from
3094bce to
606047d
Compare
Contributor
Author
|
@potiuk |
eladkal
changed the title
BeamRunPythonPipelineOperator
Member
|
There is one more "default deferrable" to fix. |
VladaZakharova
force-pushed
the
beam-python-pipeline-def
branch
from
7b217c9 to
d2f32d8
Compare
potiuk
force-pushed
the
beam-python-pipeline-def
branch
from
d2f32d8 to
6c49c4e
Compare
VladaZakharova
force-pushed
the
beam-python-pipeline-def
branch
from
6c49c4e to
c6c1852
Compare
Contributor
Author
|
@potiuk |
pankajastro
approved these changes
Jul 12, 2023
Contributor
Author
|
@potiuk @pankajastro |
Member
Hi just posted one small question otherwise looks good, |
pankajastro
reviewed
Jul 13, 2023
VladaZakharova
force-pushed
the
beam-python-pipeline-def
branch
from
9358e0e to
5f2ad03
Compare
Contributor
Author
|
@pankajastro |
pankajastro
approved these changes
Jul 13, 2023
69 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to start BeamRunPythonOperator asynchronously using deferrable mode. The documentation was updated with the description of how to work with deferrable parameter.
Additionally, the existing implementation was fixed:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.