Skip to content

TaskLogReader should check both "airflow.task" and root logger for handler #30860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dstandish merged 1 commit into from
Apr 25, 2023
Merged

TaskLogReader should check both "airflow.task" and root logger for handler #30860

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions airflow/utils/log/log_reader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,19 @@ def read_log_stream(self, ti: TaskInstance, try_number: int | None, metadata: di

@cached_property
def log_handler(self):
"""Log handler, which is configured to read logs."""
logger = logging.getLogger("airflow.task")
"""Get the log handler which is configured to read logs."""
task_log_reader = conf.get("logging", "task_log_reader")
handler = next((handler for handler in logger.handlers if handler.name == task_log_reader), None)
return handler

def handlers():
"""
Yield all handlers first from airflow.task logger then root logger.

Depending on whether we're in a running task, it could be in either of these locations.
"""
yield from logging.getLogger("airflow.task").handlers
yield from logging.getLogger().handlers

return next((h for h in handlers() if h.name == task_log_reader), None)

@property
def supports_read(self):
Expand Down