Add custom waiters to EMR Serverless #30463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
vandonr-amz
reviewed
Apr 6, 2023
syedahsn
force-pushed
the
syedahsn/emr-serverless-custom-waiters
branch
2 times, most recently
from
57fae95 to
af2a833
Compare
vandonr-amz
approved these changes
Apr 19, 2023
Contributor
vandonr-amz
left a comment
vandonr-amz
left a comment
There was a problem hiding this comment.
let's go
btw, this is going to conflict with #30720 but happy to let you go first
Member
As soon as the docs are building with no errors :) |
syedahsn
force-pushed
the
syedahsn/emr-serverless-custom-waiters
branch
from
944d724 to
c0e3180
Compare
vincbeck
reviewed
May 31, 2023
syedahsn
force-pushed
the
syedahsn/emr-serverless-custom-waiters
branch
from
c0e3180 to
97ddbac
Compare
vincbeck
approved these changes
Jun 13, 2023
Contributor
vincbeck
left a comment
vincbeck
left a comment
There was a problem hiding this comment.
Approving even though I still think using tenacity would be "better", it is just a nit
vandonr-amz
reviewed
Jun 13, 2023
vandonr-amz
reviewed
Jun 19, 2023
Update unit tests
Remove Delay from WaiterConfig
syedahsn
force-pushed
the
syedahsn/emr-serverless-custom-waiters
branch
from
97ddbac to
3f3bd4f
Compare
vandonr-amz
reviewed
Jun 20, 2023
o-nikolas
approved these changes
Jun 20, 2023
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jun 27, 2023
* Move waiter logic to utils folder --------- Co-authored-by: Raphaël Vandon <[email protected]>
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the manual waiter with the custom boto waiters. It also adds extra features to the
EmrServerlessStartJobOperator:By removing the waiters, the unit tests needed to be updated, and in some cases modified.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.