Make smtp provider tests discoverable

[potiuk]

The tests for smtp provider were placed in "smtp.py" module which made them not discoverable during pytest collection.

Changing module makes them discoverable again (they all pass BTW!)

---

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[potiuk]

I found it during testing of #30305 (which is another nice side effect of splitting tests per-provider). I found it because smtp provider tests failed as they had 0 collected tests, which is considered as failure by pytest.

[potiuk]

BTW. I wonder if we do not have similar cases elsewhere). It would be great to review our "rests" folder and possibly find (and automaticallly prevent in the future) similar problems. Any ideas?

[hussein-awala]

LGTM

[hussein-awala]

I wonder if we do not have similar cases elsewhere). It would be great to review our "rests" folder and possibly find (and automatically prevent in the future) similar problems. Any ideas?

I run a small script to check this, but I am not sure if it's enough:

from pathlib import Path

if __name__ == '__main__':
    tests_path = Path("airflow/tests")
    not_discovered_files = set(tests_path.glob('**/*.py')) - set(tests_path.glob('**/test_*.py'))
    for file in not_discovered_files:
        with open(file) as f:
            content = f.read()
            if "def test" in content or "TestCase" in content:
                print(file)

And the output is:

airflow/tests/conftest.py
airflow/tests/test_utils/asserts.py
airflow/tests/test_utils/perf/perf_kit/__init__.py
airflow/tests/providers/databricks/utils/databricks.py
airflow/tests/system/utils/__init__.py
airflow/tests/system/providers/influxdb/example_influxdb.py
airflow/tests/system/providers/amazon/aws/example_lambda.py

After checking these files, I think we should rename airflow/tests/providers/databricks/utils/databricks.py

[potiuk]

Closing - there is a better fix (and no need to have test_* prefix) in #30315