Separate out aiobotocore support to airlfow extra #30161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is follow-up after apache#30127 and apache#30144 about handling async (deferrable) operators for amazon provider. Rather than making aiobotocre directly a devel extra dependency, we create a separate "aiobotocore" extra that allows for greater flexibility on how we handle the aiobotocore support. It allows for two approach: 1) (current) if we decide that by default we keep boto/botocore compatible with aiobotocore in our constraints/image then aiobotocore should be added to devel and it should be included as preselected extra in Dockerfile. This will lead to having aibotocore and compatible boto/botocore in both constraints and the PROD image. 2) (possible) if we decide that we prefer to keep to the latest version of boto/botocore in constraints/image, then we could remove aiobotocore from both constraints and PROD image. We should also in this case swap the "LatestBoto" CI job introduced in apache#30144 to be "WithAiobotocore" job - by installing aiobotocore and downgrading boto/botocore in the job.
boring-cyborg
bot
added
area:dev-tools
area:production-image
Member
Author
o-nikolas
approved these changes
Mar 17, 2023
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow-up after #30127 and #30144 about handling async (deferrable) operators for amazon provider.
Rather than making aiobotocre directly a devel extra dependency, we create a separate "aiobotocore" extra that allows for greater flexibility on how we handle the aiobotocore support. It allows for two approach:
(current) if we decide that by default we keep boto/botocore
compatible with aiobotocore in our constraints/image then
aiobotocore should be added to devel and it should be included
as preselected extra in Dockerfile. This will lead to
having aibotocore and compatible boto/botocore in both constraints
and the PROD image.
(possible) if we decide that we prefer to keep to the latest
version of boto/botocore in constraints/image, then we could
remove aiobotocore from both constraints and PROD image. We should
also in this case swap the "LatestBoto" CI job introduced in
Run separate CI job for latest boto/botocore version when needed #30144 to be "WithAiobotocore" job - by installing aiobotocore
and downgrading boto/botocore in the job.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.