Add version_renamed and previous_name in config sections
#28324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephraimbuddy
requested review from
ashb,
jedcunningham,
kaxil and
potiuk
as code owners
Member
|
Instead of adding a bunch of I also wonder if it’s better to do renamed:
previous_name: ...
version: ...so it’s clearer the two keys must appear together. |
uranusjr
reviewed
Dec 13, 2022
ephraimbuddy
force-pushed
the
recorgnize_section_rename
branch
from
d767b3d to
9161add
Compare
uranusjr
approved these changes
Dec 13, 2022
This helps us retain the version added value of config options when the config section is renamed. This information of rename is also made available in the config documentation
ephraimbuddy
force-pushed
the
recorgnize_section_rename
branch
from
9161add to
964afea
Compare
jedcunningham
approved these changes
Dec 14, 2022
Co-authored-by: Jed Cunningham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
previous_nameandversion_renamedfields were added to the configuration section to track the previous name and the version in which it was renamed for a given configuration option.This also helps us retain the version-added value of config options when the config section is renamed.
This information of rename is also made available in the config documentation
Closes: #28076