Skip to content

Refactor SlackWebhookHook in order to use slack_sdk instead of HttpHook methods #26452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 5 commits into from
Sep 22, 2022
Merged

Refactor SlackWebhookHook in order to use slack_sdk instead of HttpHook methods #26452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0daac7a
Refactor SlackWebhookHook in order to use `slack_sdk` instead of Http…
Taragolis Sep 15, 2022
72d2ba9
Fix SnowflakeToSlackOperator tests
Taragolis Sep 18, 2022
11011e0
Add changelog
Taragolis Sep 22, 2022
69d0489
Deprecate full url in Connection host
Taragolis Sep 22, 2022
bbe3be3
Move warn about link_names in Hook constructor
Taragolis Sep 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions airflow/providers/slack/CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,16 @@
Changelog
---------

Breaking changes
~~~~~~~~~~~~~~~~

* The hook class :class:`airflow.providers.slack.hooks.slack_webhook.SlackWebhookHook` not inherit from
:class:`airflow.providers.http.hooks.http.HttpHook` anymore. In practice the only impact on
user-defined classes based on **SlackWebhookHook** and you use attributes from **HttpHook**.
* Drop support deprecated ``webhook_token`` parameter in
:ref:`Slack Incoming Webhook Connection <howto/connection:slack-incoming-webhook>` Extra.


5.1.0
.....

Expand Down
6 changes: 3 additions & 3 deletions airflow/providers/slack/hooks/slack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class SlackHook(BaseHook):

.. warning::
This hook intend to use `Slack API` connection
and might not work correctly with `Slack Webhook` and `HTTP` connections.
and might not work correctly with `Slack Incoming Webhook` and `HTTP` connections.

Takes both Slack API token directly and connection that has Slack API token. If both are
supplied, Slack API token will be used. Also exposes the rest of slack.WebClient args.
Expand All @@ -74,8 +74,8 @@ class SlackHook(BaseHook):
and receive a response from Slack. If not set than default WebClient value will use.
:param base_url: A string representing the Slack API base URL.
If not set than default WebClient BASE_URL will use (``https://www.slack.com/api/``).
:param proxy: Proxy to make the Slack Incoming Webhook call.
:param retry_handlers: List of handlers to customize retry logic in WebClient.
:param proxy: Proxy to make the Slack API call.
:param retry_handlers: List of handlers to customize retry logic in ``slack_sdk.WebClient``.
:param token: (deprecated) Slack API Token.
"""

Expand Down
Loading