Skip to content

Remove --limit-progress-output from helm-test #26144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Sep 3, 2022
Merged

Remove --limit-progress-output from helm-test #26144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 1 addition & 18 deletions dev/breeze/src/airflow_breeze/commands/testing_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,11 +306,6 @@ def tests(
)
@option_dry_run
@option_verbose
@click.option(
'--limit-progress-output',
help="Limit progress to percentage only and just show the summary when tests complete.",
is_flag=True,
)
@option_image_tag_for_running
@option_mount_sources
@click.argument('extra_pytest_args', nargs=-1, type=click.UNPROCESSED)
Expand All @@ -319,7 +314,6 @@ def helm_tests(
verbose: bool,
extra_pytest_args: Tuple,
image_tag: Optional[str],
limit_progress_output: bool,
mount_sources: str,
):
exec_shell_params = ShellParams(
Expand All @@ -334,16 +328,5 @@ def helm_tests(
perform_environment_checks(verbose=verbose)
cmd = ['docker-compose', 'run', '--service-ports', '--rm', 'airflow']
cmd.extend(list(extra_pytest_args))
if limit_progress_output:
result = run_with_progress(
cmd=cmd,
python=exec_shell_params.python,
backend=exec_shell_params.backend,
test_type='Helm',
env_variables=env_variables,
verbose=verbose,
dry_run=dry_run,
)
else:
result = run_command(cmd, verbose=verbose, dry_run=dry_run, env=env_variables, check=False)
result = run_command(cmd, verbose=verbose, dry_run=dry_run, env=env_variables, check=False)
sys.exit(result.returncode)
1 change: 0 additions & 1 deletion dev/breeze/src/airflow_breeze/commands/testing_commands_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
{
"name": "Advanced flag for helms-tests command",
"options": [
"--limit-progress-output",
"--image-tag",
"--mount-sources",
],
Expand Down
4 changes: 2 additions & 2 deletions images/breeze/output-commands-hash.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,6 @@ start-airflow:17b93add6c8ea218e9e5f0e0360d59ac
static-checks:97d324104420f051378f372d8c589d9a
stop:8ebd8a42f1003495d37b884de5ac7ce6
testing:docker-compose-tests:3e07be65e30219930d3c62a593dd8c6a
testing:helm-tests:66894434df46efe2f51bcb6dd168992d
testing:helm-tests:403231f0a94b261f9c7aae8aea03ec50
testing:tests:32deda30f3899e8ae6e241238f990d68
testing:325509289c9e2880e390a8cef687ac90
testing:e747ece268ba502c106924eb2f46c550
Loading